Add support for correlation_id to pulp #1017
Conversation
|
Attached issue: https://pulp.plan.io/issues/4689 |
daviddavis
force-pushed
the
issue4689
branch
from
4dee86a
to
4a60600
Compare
daviddavis
force-pushed
the
issue4689
branch
4 times, most recently
from
54dfdf7
to
c9b63d1
Compare
docs/settings.rst
Outdated
|
|
||
| Pulp uses ``django-guid`` to append correlation IDs to logging messages. Correlation IDs are | ||
| autogenerated by default but can also be sent as a header with each request. They are also | ||
| returned as a header in the response and are recorded inthe ``logging_cid`` field of tasks. |
| cls.task_api = TasksApi(cls.client) | ||
|
|
||
| def test_correlation_id(self): | ||
| """Test that a correlation can passed as a header and logged.""" |
There was a problem hiding this comment.
@daviddavis the pr looks good to me however i have not manually tested it
fixes #4689
| "loggers": { | ||
| "": { | ||
| # The root logger | ||
| "handlers": ["console"], | ||
| "level": "INFO", | ||
| "filters": ["correlation_id"], |
There was a problem hiding this comment.
Dec 04 16:01:39 pulp3-source-fedora32.fluffy.example.com gunicorn[44116]: pulp [None]: django_guid:INFO: Header Correlation-ID was not found in the incoming request. Generated new GUID: b9c98a1029fd4dca8be4b5725dc5236e
was it intentional to log this at the info level?
There was a problem hiding this comment.
Unfortunately yes. I'm not thrilled by it but it's what django-guid does.
There was a problem hiding this comment.
It also logs the same if I provide a correlation ID in the wrong format (not UUID). I think it's very confusing. Maybe we should file an issue/rfe about all that.
There was a problem hiding this comment.
Not sure I follow. When I submit an invalid uuid, I get:
pulp [None]: django_guid:INFO: Correlation-ID found in the header: 123
pulp [None]: django_guid:WARNING: Failed to validate GUID 123
pulp [None]: django_guid:INFO: 123 is not a valid GUID. New GUID is 487f17535a9a46f3a38dc85b9982f929
What's confusing?
There was a problem hiding this comment.
For http :/pulp/api/v3/repositories/rpm/rpm/ Corellation-ID:tadaaaaaa or POST to this, I get:
pulp [None]: django_guid:INFO: Header `Correlation-ID` was not found in the incoming request. Generated new GUID: 306940d3dad043c78992f3ac70e98ab2
I wonder if it's because it's a synchronous call and not with a task.
There was a problem hiding this comment.
/me can't spell Correlation correctly. Problem solved.
FWIW, there is a setting |
fixes #4689
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html