Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict default permissions to admin users #1064

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

mdellweg
Copy link
Member

@pulpbot
Copy link
Member

pulpbot commented Dec 23, 2020

Attached issue: https://pulp.plan.io/issues/8018

@mdellweg
Copy link
Member Author

mdellweg commented Jan 5, 2021

@jlsherrill We want to confirm with katello if you are always using the admin user.
This should not impact you then.

@jlsherrill
Copy link
Contributor

That's correct!

@ipanova
Copy link
Member

ipanova commented Jan 15, 2021

@bmbouter PTAL

@bmbouter
Copy link
Member

@newswangerd FYI on this, does galaxy_ng use any non-admin users that you don't define Permission classes explicitly for?

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a plugin writer .removal note calling out this breaking change. For example if a plugin is shipping a viewset that they need non-admin users to have access to they would want to see this in the plugin writer changelog. What do you all think about this?

@newswangerd
Copy link
Contributor

@newswangerd FYI on this, does galaxy_ng use any non-admin users that you don't define Permission classes explicitly for?

Thanks for the heads up @bmbouter. I don't think this should affect galaxy_ng too much.

@mdellweg mdellweg force-pushed the restrict_access_to_admin_user branch from d8e79ac to 30603ca Compare January 19, 2021 15:20
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdellweg mdellweg merged commit 6e8f2c9 into pulp:master Jan 19, 2021
@mdellweg mdellweg deleted the restrict_access_to_admin_user branch January 19, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants