-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict default permissions to admin users #1064
Conversation
Attached issue: https://pulp.plan.io/issues/8018 |
@jlsherrill We want to confirm with katello if you are always using the admin user. |
That's correct! |
@bmbouter PTAL |
@newswangerd FYI on this, does galaxy_ng use any non-admin users that you don't define Permission classes explicitly for? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a plugin writer .removal
note calling out this breaking change. For example if a plugin is shipping a viewset that they need non-admin users to have access to they would want to see this in the plugin writer changelog. What do you all think about this?
Thanks for the heads up @bmbouter. I don't think this should affect galaxy_ng too much. |
d8e79ac
to
30603ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #8018
https://pulp.plan.io/issues/8018