Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo attribute check to global access conditions #1088

Merged
merged 1 commit into from Jan 26, 2021

Conversation

goosemania
Copy link
Member

Plugins can leverage it at least in policies for repository version viewsets.

closes #8161
https://pulp.plan.io/issues/8161

Plugins can leverage it at least in policies for repository version viewsets.

closes #8161
https://pulp.plan.io/issues/8161
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. There are so many docstrings and such little code. I think that is a great thing actually.

Thank you for contributing this!

@pulpbot
Copy link
Member

pulpbot commented Jan 26, 2021

Attached issue: https://pulp.plan.io/issues/8161

@bmbouter
Copy link
Member

I see two lgtm's, merging!

@bmbouter bmbouter merged commit 5d79a05 into pulp:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants