New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clarifications around backport requests. #1089
Conversation
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
Thus z-stream releases will not add new migrations. | ||
Thus Z-stream releases will not add new migrations. | ||
|
||
No Z releases are planned by default. Backport requests trigger Z release planning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth re-phrasing and mention that bugfixes also trigger Z releases?
I am concerned it's not read as only backports trigger Z releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly my take away from the open floor discussion and which was a bit surprising to me.
There are no planned Z releases and any Z release works with backport requests, since we cherry-pick any fix from a master branch. Folks said that any cherry-pick action requires a backport request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a question might be if every backport leads to one Z release. I think we plan to deliver them in batches if possible. (That is multiple backports in on Z release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, "Backport requests trigger Z release planning", implies that it's not one release per request. Requests
are in plural and they trigger planning
. I'm open to phrasing suggestions, if it's not clear that it is not one release per request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goosemania thanks for sharing the background and clarification.
I still think we would need to have a Z release no matter what in case, for example, a regression has been found. It will just be one more step, most likely for us, to copy the original reported issue and open a backport. I don't foresee the user opening both issue+backport, they already struggle with finding how and where to open pulp bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hear the concern about not automatically backporting bugfixes to the latest z-stream without a backport request. I'm hoping though that once we have automated our release process, we can consider changing our release processes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
[noissue]