Add rate_limit option to Remote #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
added a commit
to fao89/pulp_ansible
that referenced
this pull request
Jan 27, 2021
Required PR: pulp/pulpcore#1091 [noissue]
bmbouter
pushed a commit
to pulp/pulp_ansible
that referenced
this pull request
Jan 27, 2021
Required PR: pulp/pulpcore#1091 [noissue]
bmbouter
reviewed
Jan 27, 2021
CHANGES/7965.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Add ``rate_limit`` option to ``Remote`` | |||
There was a problem hiding this comment.
Since users don't use this directly I think this changelog should be for plugin writers instead.
|
Attached issue: https://pulp.plan.io/issues/7965 |
bmbouter
reviewed
Jan 27, 2021
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('core', '0054_add_public_key'), |
There was a problem hiding this comment.
There is now a migration 55. https://github.com/pulp/pulpcore/tree/master/pulpcore/app/migrations
bmbouter
reviewed
Jan 27, 2021
| @property | ||
| def download_throttler(self): | ||
| """ | ||
| Return the Throttler which can be used to rate limit downloaders. |
There was a problem hiding this comment.
This dostring should have a 1-sentence summary with a line separator in between.
daviddavis
reviewed
Jan 27, 2021
pulpcore/app/models/repository.py
Outdated
Comment on lines
306
to
307
| Throttler: The instantiated Throttler to be used by | ||
| get_downloader() |
There was a problem hiding this comment.
Suggested change
| Throttler: The instantiated Throttler to be used by | |
| get_downloader() | |
| Throttler: The instantiated Throttler to be used by get_downloader() |
daviddavis
reviewed
Jan 27, 2021
pulpcore/app/models/repository.py
Outdated
| from asyncio_throttle import Throttler | ||
| import django |
There was a problem hiding this comment.
Suggested change
| from asyncio_throttle import Throttler | |
| import django | |
| import django | |
| from asyncio_throttle import Throttler |
daviddavis
approved these changes
Jan 27, 2021
|
I see two approvals! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/7965
closes #7965
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html