Fixed azure artifacts path download. #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
commented
Mar 19, 2021
| artifact_file = content_artifact.artifact.file | ||
| content_disposition = f"attachment;filename={content_artifact.relative_path}" | ||
| parameters = {"ResponseContentDisposition": content_disposition} | ||
| url = artifact_file.storage.url(artifact_file.name, parameters=parameters) | ||
| raise HTTPFound(url) | ||
| elif settings.DEFAULT_FILE_STORAGE == "storages.backends.azure_storage.AzureStorage": |
There was a problem hiding this comment.
@daviddavis should not we also set content-disposition header for Azure artifacts?
https://docs.microsoft.com/en-us/rest/api/storageservices/set-blob-properties#request-headers-all-blob-types
There was a problem hiding this comment.
I would think so but I am not familiar with Azure and I haven't tested with it at all.
There was a problem hiding this comment.
I agree, I am not familiar with Azure either. I wanted to finalize this community contribution. Can we merge this as-is and add/fix content-disposition support later on whenever we receive a bug?Thoughts?
There was a problem hiding this comment.
That sounds good to me.
|
Attached issue: https://pulp.plan.io/issues/8427 |
daviddavis
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8427
https://pulp.plan.io/issues/8427
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html