Use pulp-smash from source #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/8450 |
mdellweg
reviewed
Mar 25, 2021
functest_requirements.txt
Outdated
| pulp-smash # >=1!0.12.0 - broken: https://github.com/dependabot/dependabot-core/issues/3165 | ||
| git+git://github.com/pulp/pulp-smash@master#egg=pulp-smash |
There was a problem hiding this comment.
I think, it should replace that line.
fixes #8450
mdellweg
approved these changes
Mar 25, 2021
|
With this do we want to make a CI adjustment which I believe carries code to do the same thing? I'm not sure where that code lives tho. |
|
Also what about other plugins? The dev environment on the installer installing other plugins may bring in the pypi release of pulp_smash, and that would cause pip to believe this dep is satisfied causing the pulpcore tests to not be runnable? |
|
Random idea: what if pulp_smash was no longer a released software, and everyone used git checkouts... That way it would be the same everywhere. |
|
I emailed pulp-dev asking for objections/concerns about removing pulp-smash from PyPI. |
dralley
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8450
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html