Use https container #1283
Closed
Use https container #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
mdellweg
reviewed
Apr 28, 2021
fao89
force-pushed
the
https_container
branch
19 times, most recently
from
c382ebe
to
6050a8c
Compare
fao89
commented
Apr 30, 2021
.github/workflows/scripts/install.sh
Outdated
| @@ -91,6 +91,13 @@ fi | |||
| ansible-playbook build_container.yaml | |||
| ansible-playbook start_container.yaml | |||
|
|
|||
| # Hack: adding pulp CA to certifi.where() | |||
| sudo docker cp pulp:/etc/pulp/certs/ca.crt /usr/local/share/ca-certificates/pulp_ca.crt | |||
| CERT=$(python -c 'import certifi; print(certifi.where())') | |||
There was a problem hiding this comment.
This is Mozilla CA bundle, and I'm appending pulp CA to it
fao89
commented
Apr 30, 2021
.github/workflows/scripts/script.sh
Outdated
| @@ -79,6 +81,7 @@ if [[ "$TEST" = 'bindings' || "$TEST" = 'publish' ]]; then | |||
| gem build pulp_file_client | |||
| gem install --both ./pulp_file_client-0.gem | |||
| cd .. | |||
| export SSL_CERT_FILE=/usr/local/share/ca-certificates/pulp_ca.crt | |||
There was a problem hiding this comment.
but Ruby doesn't use certifi lib, so I had to use an OpenSSL env var to point to the CA
fao89
force-pushed
the
https_container
branch
3 times, most recently
from
72c5746
to
b9a2c95
Compare
|
Blocked by pulp/pulp-oci-images#73 or pulp/pulp-oci-images#84 |
[noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html