Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: DistributionSerializer is too prescriptive #15

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@dkliban
Copy link
Member

dkliban commented Mar 4, 2019

Solution: Add a generic BaseDistributionSerializer

re: #4435
https://pulp.plan.io/issues/4435
re: #4437
https://pulp.plan.io/issues/4437

@dkliban dkliban force-pushed the dkliban:base-distribution-serializer branch from 5e6c9df to 214f7d1 Mar 4, 2019
Solution: Add a generic BaseDistributionSerializer

re: #4435
https://pulp.plan.io/issues/4435
re: #4437
https://pulp.plan.io/issues/4437
@dkliban dkliban force-pushed the dkliban:base-distribution-serializer branch from 214f7d1 to 0eb7032 Mar 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #15 into master will decrease coverage by 1.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   76.17%   74.53%   -1.64%     
==========================================
  Files          64       64              
  Lines        2820     2824       +4     
==========================================
- Hits         2148     2105      -43     
- Misses        672      719      +47
Impacted Files Coverage Δ
pulpcore/app/serializers/__init__.py 100% <ø> (ø) ⬆️
pulpcore/app/serializers/publication.py 100% <100%> (ø) ⬆️
pulpcore/content/handler.py 28.14% <0%> (-34.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8959e35...0eb7032. Read the comment docs.

Copy link
Member

daviddavis left a comment

This LGTM

@dkliban dkliban merged commit 14f4be9 into pulp:master Mar 4, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 76.17%)
Details
codecov/project Absolute coverage decreased by -1.63% but relative coverage increased by +23.82% compared to 8959e35
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.