Fix occasional deadlocks when doing multiple similar syncs concurrently. #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/9379 |
ggainey
force-pushed
the
3_14_deadlock_work
branch
from
5c5c23e
to
a7bae1b
Compare
|
@ggainey Ready for rebase |
Forcing deadlocks requires a lot of time and pulpcore-workers running. There is therefore no specific CI test for this, but there is a reproducer script that will force deadlocks to happen (and show that they're fixed) here: https://github.com/ggainey/pulp_startup/blob/main/8750_deadlocks/file_repro.sh backports #8750 fixes #9379 (cherry picked from commit 6af3519)
ggainey
force-pushed
the
3_14_deadlock_work
branch
from
a7bae1b
to
19f688b
Compare
Fun! Ready for review. |
dralley
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing deadlocks requires a lot of time and pulpcore-workers running.
There is therefore no specific CI test for this, but there is a reproducer
script that will force deadlocks to happen (and show that they're fixed) here:
https://github.com/ggainey/pulp_startup/blob/main/8750_deadlocks/file_repro.sh
backports #8750
fixes #9379
(cherry picked from commit 6af3519)