Fix breaking changes from DRF 3.10 #213
Conversation
setup.py
Outdated
| 'djangorestframework-queryfields', | ||
| 'drf-nested-routers', | ||
| 'drf-yasg', | ||
| 'gunicorn', | ||
| 'PyYAML', | ||
| 'PyYAML>=5.1', |
There was a problem hiding this comment.
why does it need to be at least 5.1?
There was a problem hiding this comment.
DRF now pins there because of a human readability feature in OpenAPI schema generation:
encode/django-rest-framework#6680
I'm not sure if this is strictly necessary, what are your thoughts?
There was a problem hiding this comment.
I don't think it's necessary to put this minimum requirement here. Let's remove it.
There was a problem hiding this comment.
Fine by me. Removed.
CodeHeeler
force-pushed
the
issue-5125
branch
3 times, most recently
from
83a8bb2
to
9cc7ebc
Compare
pulpcore/app/openapigenerator.py
Outdated
| # needed due to https://github.com/axnsan12/drf-yasg/issues/386 | ||
| consumes = multipart | ||
| import pydevd | ||
| pydevd.settrace('localhost', port=3013, stdoutToServer=True, stderrToServer=True) |
There was a problem hiding this comment.
This breakpoint is probably causing most of the test failures on travis.
CodeHeeler
force-pushed
the
issue-5125
branch
2 times, most recently
from
3e4a29e
to
431fa28
Compare
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 67.32% 67.27% -0.06%
==========================================
Files 69 69
Lines 3223 3224 +1
==========================================
- Hits 2170 2169 -1
- Misses 1053 1055 +2
Continue to review full report at Codecov.
|
Django restframework 3.10.0 has introduced breaking changes Unpinning DRF now that a drf-yasg blocker has been fixed Required PR: pulp/pulp_file#263 fixes #5125 https://pulp.plan.io/issues/5125
Django restframework 3.10.0 has introduced breaking changes
Unpinning DRF now that a drf-yasg blocker has been fixed
fixes #5125
https://pulp.plan.io/issues/5125