Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning dependencies and using dependabot to manage updates #239

Merged
merged 1 commit into from Jul 31, 2019
Merged

Pinning dependencies and using dependabot to manage updates #239

merged 1 commit into from Jul 31, 2019

Conversation

daviddavis
Copy link
Contributor

@daviddavis daviddavis commented Jul 31, 2019 •
edited

@codecov
Copy link

codecov bot commented Jul 31, 2019 •
edited

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #239   +/-   ##
======================================
  Coverage    67.3%   67.3%           
======================================
  Files          69      69           
  Lines        3224    3224           
======================================
  Hits         2170    2170           
  Misses       1054    1054

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd2de0...3f13e2b. Read the comment docs.

@daviddavis daviddavis force-pushed the dependabot branch 2 times, most recently from 40e9e40 to 882859d Compare July 31, 2019 14:56
bmbouter
bmbouter approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

bmbouter
bmbouter reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think a changelog change should be made for this?

@daviddavis daviddavis merged commit 433775d into pulp:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daviddavis @bmbouter