New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE - identifying the type of progress report #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1e5fda
to
a2c218c
Compare
fao89
added a commit
to fao89/pulpcore-plugin
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore#289 Required PR: pulp/pulp_file#272
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 10, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
reviewed
Sep 13, 2019
CHANGES/5184.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Adding `code` on `ProgressReport` for identifying the type of progress report. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a feature.
fao89
added a commit
to fao89/pulpcore-plugin
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore#289 Required PR: pulp/pulp_file#272
fao89
added a commit
to fao89/pulpcore-plugin
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore#289 Required PR: pulp/pulp_file#272
fao89
added a commit
to fao89/pulp_file
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
closes #5184 Required PR: pulp/pulp_file#272 Required PR: pulp/pulpcore-plugin#123 https://pulp.plan.io/issues/5184
daviddavis
approved these changes
Sep 13, 2019
daviddavis
pushed a commit
to pulp/pulp_ansible
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Sep 13, 2019
ref #5184 https://pulp.plan.io/issues/5184 Required PR: pulp/pulpcore-plugin#123 Required PR: pulp/pulpcore#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5184
https://pulp.plan.io/issues/5184
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html
MERGE on Sep 13th