Remove custom JSONField implementation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change LGTM. Just need to fix Travis. |
dralley
force-pushed
the
rm-jsonfield
branch
3 times, most recently
from
7443d98
to
e790204
Compare
Remove our TextField-based JSONField implementation and use the PostgreSQL Django-supplied one instead. closes: #5465 https://pulp.plan.io/issues/5465
dralley
force-pushed
the
rm-jsonfield
branch
from
e790204
to
0946214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quick to do and since it requires a redo of all the migrations I figured it would be good timing to do it at the same time as Fabricio's PR that will also need to redo the migrations