Remove NamePagination class #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting of the results can be accomplished on the queryset. fixes #5489 https://pulp.plan.io/issues/5489
mdellweg
force-pushed
the
remove_name_pagination
branch
from
44c65fb
to
36d4cd2
Compare
nixocio
approved these changes
Sep 24, 2019
|
LGTM. Mind sending out a '[BREAKING]' announcement to pulp-dev? |
|
@daviddavis So this is going to be a thing? |
|
Yes, but only until 3.0 GA probably as we shouldn't have breaking changes after 3.0 GA (due to semver). Let's merge tomorrow I think. I don't think there are plugins using this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting of the results can be accomplished on the queryset.
fixes #5489
https://pulp.plan.io/issues/5489