Fix Detail viewsets erroneous namespacing #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Oct 2, 2019
Required PR: pulp/pulpcore#319 refs #5533
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Oct 2, 2019
Required PR: pulp/pulpcore#319 refs #5533
daviddavis
changed the title
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Oct 2, 2019
Required PR: pulp/pulpcore#319 ref #5533
daviddavis
force-pushed
the
issue5533
branch
2 times, most recently
from
16966e7
to
309332f
Compare
daviddavis
changed the title
If there is no Master viewset, don't automatically try to namespace the viewset endpoint as it erroneously namespaces the endpoint with the detail viewset's endpoint_name. fixes #5533 https://pulp.plan.io/issues/5533
goosemania
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no Master viewset, don't automatically try to namespace the
viewset endpoint as it erroneously namespaces the endpoint with the
detail viewset's endpoint_name.
fixes #5533
https://pulp.plan.io/issues/5533
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html