Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a ReadOnlyContentViewSet #322

Merged
merged 1 commit into from Oct 3, 2019
Merged

Conversation

goosemania
Copy link
Member

goosemania added a commit to goosemania/pulpcore-plugin that referenced this pull request Oct 3, 2019
goosemania added a commit to goosemania/pulpcore-plugin that referenced this pull request Oct 3, 2019
@@ -0,0 +1,2 @@
Introduce a ReadOnlyContentViewSet to expose in Plugin API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra line I think will cause inconsistent spacing in the release notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. If you don't mind fixing the extra line in the release note before merging that would be cool.

goosemania added a commit to goosemania/pulpcore-plugin that referenced this pull request Oct 3, 2019
@goosemania goosemania merged commit 4d22cf7 into pulp:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants