Remove unused pulpcore.plugin objects

[bmbouter]

This was done by an audit against master for pulp_rpm, pulp_container,
pulp_file, pulp_deb, pulp-certguard, and pulp_cookbook.

pulp_container will require a small update replacing its CharInFilter
usage.

https://pulp.plan.io/issues/5693
closes #5693

[bmbouter]

pulp_container needs an update replacing its https://github.com/pulp/pulp_container/blob/c924075a7d6817840cf6a58d324680170dd09564/pulp_container/app/viewsets.py#L42 with direct usage of

pulpcore/pulpcore/app/viewsets/custom_filters.py

Line 249 in 4029a85

class CharInFilter(BaseInFilter, CharFilter):

[goosemania]

@bmbouter ,
RPM plugin uses MultipleArtifactContentSerializer and Model.
Migration plugin uses Model, IdentityField, HyperlinkRelatedFilter.

Model will become BaseModel, and what to do with the rest? Direct import?

Let's coordinate the merge/cherry-pick, so RPM plugin is not broken for long.

[goosemania]

I think it's better to mention all the objects which are removed from the plugin API, so plugin writers are not surprised that something disappeared.

[bmbouter]

Good idea! I will add those here.

[ipanova]

@bmbouter pulp_container uses CharInFilter, since

pulp_container needs an update replacing its https://github.com/pulp/pulp_container/blob/c924075a7d6817840cf6a58d324680170dd09564/pulp_container/app/viewsets.py#L42 with direct usage of

pulpcore/pulpcore/app/viewsets/custom_filters.py

Line 249 in 4029a85

class CharInFilter(BaseInFilter, CharFilter):

ok

[bmbouter]

@bmbouter ,
RPM plugin uses MultipleArtifactContentSerializer and Model.
Migration plugin uses Model, IdentityField, HyperlinkRelatedFilter.

Let me back out these changes

Model will become BaseModel, and what to do with the rest? Direct import?

Yes I'm going to try to open PRs to fix this before merging this.

Let's coordinate the merge/cherry-pick, so RPM plugin is not broken for long.

👍

[bmbouter]

I added back MultipleArtifactContentSerializer, IdentityField, HyperlinkRelatedFilter, and CharInField to keep things simple. So really the main change is the Model -> BaseModel. That is motivated because our API shouldn't compete with Django for the actual Model (django is the real one).

[bmbouter]

I also added the removals in release notes.

[bmbouter]

Here's the corresponding pulp_rpm PR: pulp/pulp_rpm#1546 I'm making one for pulp_container now too.

[bmbouter]

I realized pulp_container didn't need an update, but pulp-2to3-migraiton does: pulp/pulp-2to3-migration#53

[goosemania]

Thank you!