Improve speed and memory performance of syncing #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Dec 5, 2019
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#440 closes #5688
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Dec 5, 2019
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#440 closes #5688
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Dec 5, 2019
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#440 closes #5688
fao89
commented
Dec 5, 2019
| @@ -71,3 +71,20 @@ def get_view_name_for_model(model_obj, view_action): | |||
| if registered_viewset is viewset: | |||
| return '-'.join((base_name, view_action)) | |||
| raise LookupError('view not found') | |||
|
|
|||
|
|
|||
| def batch_qs(qs, batch_size=1000): | |||
There was a problem hiding this comment.
dralley
changed the title
bmbouter
reviewed
Dec 6, 2019
| @@ -496,6 +500,9 @@ def remove_content(self, content): | |||
| if self.complete: | |||
| raise ResourceImmutableError(self) | |||
|
|
|||
| if not content or not content.count(): | |||
There was a problem hiding this comment.
SQLAlchemy enforces to not pass an empty list due performance problems: https://developpaper.com/query-empty-list-problem-analysis-of-sql-alchemy-in/
So I did it to see how it would affect performance on django orm, and I notice a 300 seconds difference from my previous test without this.
There was a problem hiding this comment.
Yup that makes sense. Thank you.
bmbouter
approved these changes
Dec 6, 2019
💯
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Dec 9, 2019
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#440 closes #5688
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Dec 9, 2019
https://pulp.plan.io/issues/5688 Required PR: pulp/pulpcore#440 closes #5688
fao89
commented
Mar 1, 2021
| @@ -15,7 +15,7 @@ | |||
| _logger = logging.getLogger(__name__) | |||
|
|
|||
| # number of ms between save() calls when _using_context_manager is set | |||
| BATCH_INTERVAL = 500 | |||
| BATCH_INTERVAL = 2000 | |||
There was a problem hiding this comment.
@gerrod3 @bmbouter @daviddavis maybe we need to change these numbers for pulp_ansible sync ?
fao89
commented
Mar 1, 2021
| @@ -81,7 +81,7 @@ async def run(self): | |||
| log.debug(_('%(name)s - next: %(content)s.'), {'name': self, 'content': content}) | |||
| yield content | |||
|
|
|||
| async def batches(self, minsize=50): | |||
| async def batches(self, minsize=500): | |||
There was a problem hiding this comment.
@gerrod3 @bmbouter @daviddavis maybe we need to change these numbers for pulp_ansible sync?
fao89
commented
Mar 1, 2021
| @@ -163,7 +163,7 @@ def __str__(self): | |||
| return '[{id}] {name}'.format(id=id(self), name=self.__class__.__name__) | |||
|
|
|||
|
|
|||
| async def create_pipeline(stages, maxsize=100): | |||
| async def create_pipeline(stages, maxsize=1000): | |||
There was a problem hiding this comment.
@gerrod3 @bmbouter @daviddavis maybe we need to change these numbers for pulp_ansible sync?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/5688
ref #5688
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html