Copy files when they originate out of MEDIA_ROOT #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
force-pushed
the
switch-save-to-leave-files-in-tact
branch
2 times, most recently
from
a6cd20a
to
a3f3c15
Compare
bmbouter
force-pushed
the
switch-save-to-leave-files-in-tact
branch
4 times, most recently
from
b4dbddc
to
eb60095
Compare
bmbouter
changed the title
daviddavis
reviewed
Jan 10, 2020
bmbouter
force-pushed
the
switch-save-to-leave-files-in-tact
branch
from
eb60095
to
b20fd8d
Compare
dkliban
reviewed
Jan 10, 2020
| _file.close() | ||
| else: | ||
| os.close(fd) | ||
| except FileExistsError: |
There was a problem hiding this comment.
Can you refactor this except so that it is more closely located to the code that emits the exception?
There was a problem hiding this comment.
yes! I pushed that just now.
There was a problem hiding this comment.
That fails on the open due to the 0o666 open mode, so the exception handler being down here is needed.
bmbouter
force-pushed
the
switch-save-to-leave-files-in-tact
branch
from
b20fd8d
to
78e8fda
Compare
dkliban
approved these changes
Jan 10, 2020
Django would move files in cases where the source was a file:/// repository. https://pulp.plan.io/issues/5941 closes #5941 https://pulp.plan.io/issues/5870 closes #5870
bmbouter
force-pushed
the
switch-save-to-leave-files-in-tact
branch
from
78e8fda
to
07340fd
Compare
daviddavis
approved these changes
Jan 10, 2020
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django would move files in cases where the source was a file:///
repository.
https://pulp.plan.io/issues/5941
closes #5941
https://pulp.plan.io/issues/5870
closes #5870