Re-pin redis version to fix freezing issue #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
reviewed
Jan 21, 2020
setup.py
Outdated
| @@ -19,6 +19,7 @@ | |||
| 'pygtrie~=2.3.2', | |||
| 'psycopg2>=2.7,<2.9', | |||
| 'PyYAML>=5.1.1,<5.4.0', | |||
| 'redis~=3.1.0', | |||
There was a problem hiding this comment.
Can we have an issue tracking the defect (even a 1-liner to have the issue number), and have a comment here linking to it?
There was a problem hiding this comment.
There was a problem hiding this comment.
@dralley can you add the comment here also? I'm concerned that without it someone could upgrade and subtly re-introduce the issue. Wdyt?
|
@gmbnomis may have found a solution: redis/redis-py#1138 (comment) |
dralley
force-pushed
the
master
branch
4 times, most recently
from
1e2380f
to
2f8bad4
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]