RelatedField return empty strings instead of None #536

fao89 · 2020-02-11T21:47:17Z

Reference:

https://pulp.plan.io/issues/6069#note-7

[noissue] Reference: https://pulp.plan.io/issues/6069#note-7

dkliban · 2020-02-11T21:57:37Z

pulpcore/app/serializers/base.py

+        # Return empty string instead of None
+        try:
+            attr = get_attribute(instance, self.source_attrs)
+        except Exception:


What kind of exception is possible here?

BuiltinSignatureError, KeyError, AttributeError:
https://github.com/encode/django-rest-framework/blob/master/rest_framework/fields.py#L449-L488

fao89 · 2020-02-12T13:31:13Z

This PR is a PoC, I don't know if the best approach is changing _DetailFieldMixin, maybe a better option would be creating a specific field for it like StringDetailRelatedField. I just wanted to see how bindings would behave if instead of getting None it received an empty string.
It seems to work, as you can see on the gist:
https://gist.github.com/fabricio-aguiar/40eef40aec26feae1c3f03c515c4ca73

RelatedField return empty strings instead of None

b570955

[noissue] Reference: https://pulp.plan.io/issues/6069#note-7

fao89 requested a review from dkliban February 11, 2020 21:47

dkliban reviewed Feb 11, 2020

View reviewed changes

fao89 closed this Feb 12, 2020

RelatedField return empty strings instead of None #536

RelatedField return empty strings instead of None #536

fao89 commented Feb 11, 2020 •

edited

dkliban Feb 11, 2020

fao89 Feb 11, 2020

fao89 commented Feb 12, 2020 •

edited

RelatedField return empty strings instead of None #536

RelatedField return empty strings instead of None #536

Conversation

fao89 commented Feb 11, 2020 • edited

Reference:

dkliban Feb 11, 2020

Choose a reason for hiding this comment

fao89 Feb 11, 2020

Choose a reason for hiding this comment

fao89 commented Feb 12, 2020 • edited

fao89 commented Feb 11, 2020 •

edited

fao89 commented Feb 12, 2020 •

edited