Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to filter SigningService by name #558

Merged
merged 1 commit into from Mar 3, 2020
Merged

Allow to filter SigningService by name #558

merged 1 commit into from Mar 3, 2020

Conversation

mdellweg
Copy link
Member

No description provided.

mdellweg
mdellweg commented Feb 21, 2020
View reviewed changes
pulpcore/app/models/content.py
@@ -459,7 +459,10 @@ def sign(self, filename):

"""
completed_process = subprocess.run(
[self.script, filename], stdout=subprocess.PIPE, stderr=subprocess.PIPE
[self.script, filename],
env={},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this, because the script inherited the complete environment of Django.

@bmbouter
Copy link
Member

@mdellweg Can we add a changelog entry for this? Since it's a new feature I try to have an entry for any non-trivial change. To do that file a story (even a short one is fine) and then use that number for your commit and CHANGES entry please.

bmbouter
bmbouter reviewed Feb 21, 2020
View reviewed changes
pulpcore/plugin/models/__init__.py
@@ -24,5 +24,6 @@
RepositoryContent,
RepositoryVersion,
RepositoryVersionDistribution,
SigningService,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs it's own changelog entry also please.

bmbouter
bmbouter requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changelog entry changes for this. See earlier comments.

@mdellweg
Copy link
Member Author

I will add tickets and changelogs next week, when I'm back in the office.
If it turns out to be urgent, please take any action needed.

@bmbouter
Copy link
Member

@mdellweg next week sounds fine. My interest was more to make it clear to anyone coming across the PR that it's status is reviewed and waiting for changelog changes. Thank you!

@lubosmj
Allow to filter SigningService by name
85b2dc6 
Also run signing script in a clean environment.

fixes #6256, #6257

Co-Authored-By: Ľuboš Mjachky <lmjachky@redhat.com>
@mdellweg
Copy link
Member Author

mdellweg commented Mar 2, 2020

ping @bmbouter

mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
97e67bb 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
859237c 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
bbe5fa7 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
e303e1d 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
c5e6ac3 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
6eb3211 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
52ca515 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
770d002 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
8b65265 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
4f8540d 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
0ebc41e 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
083a5db 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 2, 2020
Add Release signing to publishing
e04eacd 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
82a2d24 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
9ecc732 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
d6d255b 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
5d79a4f 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
8c60a0f 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
56656f5 
Required PR: pulp/pulpcore#558

fixes #6171
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
2eeb37c 
Required PR: pulp/pulpcore#558

fixes #6171
@mdellweg mdellweg mentioned this pull request Mar 3, 2020
Closed
mdellweg pushed a commit to mdellweg/pulp_deb that referenced this pull request Mar 3, 2020
Add Release signing to publishing
986e03a 
Required PR: pulp/pulpcore#558

fixes #6171
dkliban
dkliban approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@dkliban dkliban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @bmbouter, please review also.

bmbouter
bmbouter approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmbouter bmbouter merged commit a217301 into pulp:master Mar 3, 2020
@mdellweg mdellweg deleted the expose_signing_service branch March 4, 2020 09:00
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 13, 2020
@quba42
Add Release signing to publishing
8a0b4f7 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 13, 2020
@quba42
Add Release signing to publishing
e763a7b 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 13, 2020
@quba42
Add Release signing to publishing
39ed606 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 16, 2020
@quba42
Add Release signing to publishing
d41a134 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 16, 2020
@quba42
Add Release signing to publishing
1c73338 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 16, 2020
@quba42
Add Release signing to publishing
e566050 
Required PR: pulp/pulpcore#558

fixes #6171
quba42 pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Mar 17, 2020
@quba42
Add Release signing to publishing
771a0af 
Required PR: pulp/pulpcore#558

fixes #6171
ThikaXer pushed a commit to ATIX-AG/pulp_deb that referenced this pull request Oct 5, 2020
Add Release signing to publishing
4558356 
Required PR: pulp/pulpcore#558

fixes #6171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubosmj lubosmj lubosmj left review comments

@bmbouter bmbouter bmbouter approved these changes

@dkliban dkliban dkliban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdellweg @bmbouter @dkliban @lubosmj