Generate bindings for views/viewsets without model #577
Conversation
CHANGES/5238.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Generate bindings for views/viewsets without model | |||
There was a problem hiding this comment.
Should this be paste tense with the new changelog style we are using?
There was a problem hiding this comment.
Also the issue 5238 is for pulp_ansible, but this change is in core. Since pulpcore releases seperately from pulp_ansible, we end up in a strange position where we can't move it to CLOSED - CURRENT RELEASE unless both projects release. For this reason I avoid having pulpcore issues refer to any issue that isn't in the "core project" in Redmine.
I you agree w/ this, my suggestion is to file a new issue to track the defect that was in pulpcore specifically, and have your issue reference, refer to that one instead. Then relate the two issues in Redmine also.
Wdyt?
fao89
force-pushed
the
5238
branch
3 times, most recently
from
27a91fd
to
9269111
Compare
| @@ -374,9 +402,11 @@ def get_tags(self, operation_keys): | |||
| list[str] of tags | |||
| """ | |||
| tags = self.overrides.get('tags') | |||
| full_tag = getattr(self.view, "pulp_full_tag", False) | |||
There was a problem hiding this comment.
tags are the things that identify the API, grouping it.
Tags are what you see on the left column: https://pulp-ansible.readthedocs.io/en/latest/restapi.html
They are formed by the URL:
/pulp_ansible/galaxy/{path}/api/v2/collections/ == Pulp_Ansible: Galaxy Api V2 Collections
On bindings:
Pulp_Ansible: Galaxy Api V2 Collections == class PulpAnsibleGalaxyApiV2CollectionsApi
As you can see below, we are deleting some word from the tag, which in some cases deleted v2 or v3, gathering everything in one API. This full_tag is for assuring galaxy APIs won't have any word deleted
| resource_name = view.__name__.replace("ViewSet", "").replace("View", "") | ||
| param_name = path | ||
| resource_model = get_model_from_view(view) | ||
| slug_model = getattr(view, "pulp_slug", True) |
There was a problem hiding this comment.
pulp_slug was introduced to check if we want the current path URL or if we want a model URL e.g. pulp_href.
For CollectionImport:
pulp_slug = True => collection_import_href
pulp_slug = False => pulp_ansible/galaxy/{path}/api/v2/collection-imports/{task}/
In this specific case, as collection_import_href points to v3. It is a trick to differentiate v2 and v3 as they use the same viewset:
views_v3.CollectionImportViewSet: https://github.com/pulp/pulp_ansible/blob/master/pulp_ansible/app/urls.py#L36
|
Attached issue: https://pulp.plan.io/issues/6369 |
|
This PR is important to me, but I likely need until next Wednesday before I can look at it. Sorry for the delay. I have a reminder, but please remind me again if that is ok. |
|
I rebased the PR and now it is failing due certguard |
|
If you rerun it now it should pass I believe. The failing test should be skipping now temporarily. |
|
Closing in favor of:
|
https://pulp.plan.io/issues/6369
closes #6369
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html