Port pulpcore-content to use Application Runners #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6397 |
bmbouter
force-pushed
the
port-content-app-to-application-runners
branch
from
f814492
to
f7446ff
Compare
Application Runners in aiohttp Server are the recommended way to configure additional aspects of aiohttp such configuring the header length. Plugins like `pulp-certguard` require this additional configuration. This PR ports the `pulp-content` app to use Application Runners. Also port the `pulpcore.content.app` entry point that gunicorn uses to it also. https://pulp.plan.io/issues/6397 closes #6397
bmbouter
force-pushed
the
port-content-app-to-application-runners
branch
from
f7446ff
to
832f317
Compare
mdellweg
reviewed
Apr 28, 2020
| import django # noqa otherwise E402: module level not at top of file | ||
| django.setup() # noqa otherwise E402: module level not at top of file | ||
|
|
||
| from django.conf import settings |
There was a problem hiding this comment.
I do not see those settings to be used anywhere (yet?).
| app, | ||
| max_line_size=16380, | ||
| max_field_size=16380 | ||
| ) |
There was a problem hiding this comment.
Is this PulpGunicornWebWorker used anywhere?
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application Runners in aiohttp Server are the recommended way to
configure additional aspects of aiohttp such configuring the header
length. Plugins like
pulp-certguardrequire this additionalconfiguration.
This PR ports the
pulp-contentapp to use Application Runners. Alsoport the
pulpcore.content.appentry point that gunicorn uses to italso.
https://pulp.plan.io/issues/6397
closes #6397