New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] django-admin for pulp #630
Conversation
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
|
I was talking about this at the pulpcore checkin meeting, and some practical concerns that came up in using django-admin with Pulp. We are thinking we should document users not to expect it and why. I created an issue here to document why something so well-known and useful in the Django community is probably not a good fit for Pulp. https://pulp.plan.io/issues/6475 Assuming the DRF browsable API provides most read functionality, can you call out the API gaps pulp has that caused you to want to use django-admin in the first place? In terms of this PR we probably should close it since the current thinking is that it isn't safe with Pulp. |
|
For my uses, there tends to be cases where I would find django-admin useful.
|
[noissue]
closes #6565 https://pulp.plan.io/issues/6565 (cherry picked from commit 8c6d01d)
|
I rebased this, and split it into two prs. One for just enabling a /admin url. And #705 that adds some slightly customized AdminModels. |
|
With my RBAC proof of concept it likely will also use django-admin. I hope to have it to a ready-to-discuss state by end of next week. At that time I also want to look at the django admin functionality this provides to see what a "total django admin" user experience would look like. In other words, I'll review this hopefully in about a week from now. Thanks for submitting. |
Enable django-admin, and include some ModelAdmin's generated with
https://django-extensions.readthedocs.io/en/latest/admin_generator.html
Enabling django-admin in pulpcore makes it easier to use it in plugins.
provide django-admin setup for dealing with models that use core models, they don't need to
bundle or duplicate them.
It's been a few weeks since I last updated the ModelAdmin stuff, so it may be slightly out of sync.
It would probably be useful to automate the process of build the admin pages, so things dont drift.