Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT exporter testcases #661

Merged
merged 1 commit into from Apr 22, 2020
Merged

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Apr 21, 2020

Required some tweaks to model/serializer code to handle deletes and binding-calls.

[noissue]

@ggainey ggainey requested a review from a team April 21, 2020 19:45
@pulpbot
Copy link
Member

pulpbot commented Apr 21, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@daviddavis
Copy link
Contributor

@ggainey you should be able to set ALLOWED_PATHS in the template config. See pulp_ansible here as an example.

@ggainey
Copy link
Contributor Author

ggainey commented Apr 22, 2020

@ggainey you should be able to set ALLOWED_PATHS in the template config. See pulp_ansible here as an example.

Awesome - changes pushed, let's see what happens!

@ggainey ggainey force-pushed the exporter-test-cases branch 5 times, most recently from 5cf7dcf to fb3f63e Compare April 22, 2020 18:27
Required some tweaks to model/serializer code to handle deletes and binding-calls.
Required adding default-settings for ALLOWED_EXPORT_PATHS for Travis, and therefore
required regnerating the .travis scripts

fixes: #6539
@@ -133,6 +134,7 @@ class PulpExporterSerializer(ExporterSerializer):
queryset=models.PulpExport.objects.all(),
many=False,
required=False,
allow_null=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too.

@daviddavis daviddavis merged commit d522ac4 into pulp:master Apr 22, 2020
@ggainey ggainey deleted the exporter-test-cases branch May 11, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants