New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT exporter testcases #661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
3b2bd73
to
c4ff63f
Compare
daviddavis
reviewed
Apr 21, 2020
daviddavis
reviewed
Apr 21, 2020
daviddavis
reviewed
Apr 21, 2020
daviddavis
reviewed
Apr 21, 2020
daviddavis
reviewed
Apr 21, 2020
daviddavis
reviewed
Apr 21, 2020
c4ff63f
to
f53b0a6
Compare
f53b0a6
to
7766909
Compare
5cf7dcf
to
fb3f63e
Compare
Required some tweaks to model/serializer code to handle deletes and binding-calls. Required adding default-settings for ALLOWED_EXPORT_PATHS for Travis, and therefore required regnerating the .travis scripts fixes: #6539
fb3f63e
to
c678c1f
Compare
daviddavis
reviewed
Apr 22, 2020
daviddavis
reviewed
Apr 22, 2020
| @@ -133,6 +134,7 @@ class PulpExporterSerializer(ExporterSerializer): | |||
| queryset=models.PulpExport.objects.all(), | |||
| many=False, | |||
| required=False, | |||
| allow_null=True, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too.
daviddavis
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required some tweaks to model/serializer code to handle deletes and binding-calls.
[noissue]