Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Black formatting #663

Merged
merged 4 commits into from Apr 29, 2020
Merged

Activate Black formatting #663

merged 4 commits into from Apr 29, 2020

Conversation

mdellweg
Copy link
Member

[noissue]

@mdellweg mdellweg requested a review from a team April 22, 2020 15:12
@pulpbot
Copy link
Member

pulpbot commented Apr 22, 2020

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@daviddavis
Copy link
Contributor

This is great. I'm glad someone finally got around to this. A couple things. There is an issue for this work. Also, this is a huge change and I think we should probably send out a notice to pulp-dev with a merge date (April 30?) to give developers a chance to merge any open PRs, etc.

@mdellweg
Copy link
Member Author

I figured right after a Release might be the right time. I'll take that issue then.

@mdellweg mdellweg force-pushed the black branch 5 times, most recently from 522de32 to 68974aa Compare April 28, 2020 12:30
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you want to squash the commits together?

@daviddavis
Copy link
Contributor

Talked to @bmbouter and we decided to squash and merge. Thank you @mdellweg!

@daviddavis daviddavis merged commit b94abd6 into pulp:master Apr 29, 2020
@mdellweg mdellweg deleted the black branch April 29, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants