Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task groups to the Plugin API #677

Merged
merged 1 commit into from Apr 29, 2020
Merged

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Apr 28, 2020

Somehow this never got added to the plugin API even though I remember making the change, it must have gotten accidentally stashed or something. There's already a changelog entry... we can send this out in a Y release.

re: #6414
https://pulp.plan.io/issues/6414

@pulpbot
Copy link
Member

pulpbot commented Apr 28, 2020

Warning: Issue #6414 is not at NEW/ASSIGNED/POST.

daviddavis
daviddavis previously approved these changes Apr 28, 2020
@daviddavis
Copy link
Contributor

I thought this over and I think we need a new issue that we can add to a 3.3.1 milestone plus changelog entry that will show up in the 3.3.1 changelog.

@dralley
Copy link
Contributor Author

dralley commented Apr 28, 2020

The changelog entry that already went out in 3.3.0 already mentions "plugin writers", so it arguably doesn't need a changelog entry. wdyt?

Here's what it says:

Task Groups added -- Plugin writers can spawn tasks as part of a "task group", which facilitates easier monitoring of related tasks

@daviddavis
Copy link
Contributor

If #6414 were unreleased (and at MODIFIED) then I think it would be ok. My understanding of our release process though is that we can't/shouldn't attach changes to released issues.

@dralley dralley force-pushed the task-groups branch 3 times, most recently from 593ff5c to ecdee6f Compare April 29, 2020 16:01
@dralley dralley merged commit 6ef93ff into pulp:master Apr 29, 2020
@dralley dralley deleted the task-groups branch April 29, 2020 17:08
@bmbouter
Copy link
Member

If #6414 were unreleased (and at MODIFIED) then I think it would be ok. My understanding of our release process though is that we can't/shouldn't attach changes to released issues.

This is also my understanding. An issue can't be fixed in two releases. Additionally it creates issues for any downstream during their cherry picking process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants