Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Pulp 3 Default Ports #75

Merged
merged 2 commits into from Apr 11, 2019
Merged

Change Pulp 3 Default Ports #75

merged 2 commits into from Apr 11, 2019

Conversation

@mikedep333
Copy link
Contributor

mikedep333 commented Apr 9, 2019

Change Pulp 3 Default Ports
https://pulp.plan.io/issues/4556

Update docs for changed Pulp 3 Default Ports
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

This commit includes a change to docs/Makefile that affects the build process.

Note: I am about to submit changes to ansible-pulp & several other repos too. The travis files exist in those other repos in addition to doc updates. They probably all need to be merged at the same time.

Required PR: #79

@mikedep333 mikedep333 force-pushed the mikedep333:default-ports branch from 5b83a94 to 4d3fff5 Apr 9, 2019
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/devel that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/ansible-pulp that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulpcore-plugin that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_file that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_file that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_deb that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_deb that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_deb that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_deb that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
@mikedep333 mikedep333 force-pushed the mikedep333:default-ports branch from 4d3fff5 to d67fc44 Apr 9, 2019
mikedep333 added a commit to mikedep333/pulp_file that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_file that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulpcore-plugin that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 9, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #75 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   65.62%   65.59%   -0.04%     
==========================================
  Files          65       65              
  Lines        3020     3020              
==========================================
- Hits         1982     1981       -1     
- Misses       1038     1039       +1
Impacted Files Coverage Δ
pulpcore/app/viewsets/repository.py 98.54% <ø> (ø) ⬆️
pulpcore/app/viewsets/task.py 91.04% <0%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a51088...89d7311. Read the comment docs.

@mikedep333 mikedep333 force-pushed the mikedep333:default-ports branch from d67fc44 to 78b927e Apr 10, 2019
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 10, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_file that referenced this pull request Apr 10, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_deb that referenced this pull request Apr 10, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
@mikedep333 mikedep333 mentioned this pull request Apr 10, 2019
@mikedep333 mikedep333 force-pushed the mikedep333:default-ports branch 3 times, most recently from 23563fe to 7248e44 Apr 11, 2019
@@ -170,7 +170,7 @@ class RepositoryVersionFilter(BaseFilterSet):
# /?number__range=4,6
# /?_created__gte=2018-04-12T19:45
# /?_created__range=2018-04-12T19:45,2018-04-13T20:00
# /?content=http://localhost:8000/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/
# /?content=http://localhost:24817/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/

This comment has been minimized.

Copy link
@dkliban

dkliban Apr 11, 2019

Member

this needs to be just the relative URL without the hostname and port. What was here before was wrong.

This comment has been minimized.

Copy link
@mikedep333

mikedep333 Apr 11, 2019

Author Contributor

@dkliban Fixed.

mikedep333 added 2 commits Apr 9, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

Also fix a related issue with a URL in a comment:
It should be relative rather than absolute.

[noissue]
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
@mikedep333 mikedep333 force-pushed the mikedep333:default-ports branch from 7248e44 to 89d7311 Apr 11, 2019
@dkliban dkliban merged commit 8d1f8b1 into pulp:master Apr 11, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 65.59% (-0.04%) compared to 1a51088
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 1a51088...89d7311
Details
mikedep333 added a commit to mikedep333/pulp-ci that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_rpm that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/ansible-pulp that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
dkliban added a commit to pulp/pulp-certguard that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
dkliban added a commit to pulp/pulp-certguard that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/plugin_template that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/plugin_template that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_cookbook that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_cookbook that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_gem that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_gem that referenced this pull request Apr 11, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_gem that referenced this pull request Apr 12, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
mikedep333 added a commit to mikedep333/pulp_gem that referenced this pull request Apr 12, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
daviddavis added a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
daviddavis added a commit to daviddavis/pulp_file that referenced this pull request May 14, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
daviddavis added a commit to daviddavis/plugin_template that referenced this pull request Jul 8, 2019
https://pulp.plan.io/issues/4556

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
daviddavis added a commit to daviddavis/plugin_template that referenced this pull request Jul 8, 2019
https://pulp.plan.io/issues/4594

Content: 8080 -> 24816
API: 8000 -> 24817

[noissue]
Required PR: pulp/pulpcore#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.