New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Pulp 3 Default Ports #75
Conversation
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 65.62% 65.59% -0.04%
==========================================
Files 65 65
Lines 3020 3020
==========================================
- Hits 1982 1981 -1
- Misses 1038 1039 +1
Continue to review full report at Codecov.
|
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
23563fe
to
7248e44
Compare
pulpcore/app/viewsets/repository.py
Outdated
@@ -170,7 +170,7 @@ class RepositoryVersionFilter(BaseFilterSet): | |||
# /?number__range=4,6 | |||
# /?_created__gte=2018-04-12T19:45 | |||
# /?_created__range=2018-04-12T19:45,2018-04-13T20:00 | |||
# /?content=http://localhost:8000/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/ | |||
# /?content=http://localhost:24817/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be just the relative URL without the hostname and port. What was here before was wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkliban Fixed.
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 Also fix a related issue with a URL in a comment: It should be relative rather than absolute. [noissue]
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue]
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
Change Pulp 3 Default Ports
https://pulp.plan.io/issues/4556
Update docs for changed Pulp 3 Default Ports
https://pulp.plan.io/issues/4594
Content: 8080 -> 24816
API: 8000 -> 24817
This commit includes a change to docs/Makefile that affects the build process.
Note: I am about to submit changes to ansible-pulp & several other repos too. The travis files exist in those other repos in addition to doc updates. They probably all need to be merged at the same time.
Required PR: #79