Change Pulp 3 Default Ports #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/devel
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/ansible-pulp
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulpcore-plugin
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_file
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_file
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_deb
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_deb
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_deb
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_deb
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_file
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_file
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulpcore-plugin
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 9, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 65.62% 65.59% -0.04%
==========================================
Files 65 65
Lines 3020 3020
==========================================
- Hits 1982 1981 -1
- Misses 1038 1039 +1
Continue to review full report at Codecov.
|
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 10, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_file
that referenced
this issue
Apr 10, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_deb
that referenced
this issue
Apr 10, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
force-pushed
the
default-ports
branch
2 times, most recently
from
23563fe
to
7248e44
Compare
dkliban
reviewed
Apr 11, 2019
pulpcore/app/viewsets/repository.py
Outdated
| @@ -170,7 +170,7 @@ class RepositoryVersionFilter(BaseFilterSet): | |||
| # /?number__range=4,6 | |||
| # /?_created__gte=2018-04-12T19:45 | |||
| # /?_created__range=2018-04-12T19:45,2018-04-13T20:00 | |||
| # /?content=http://localhost:8000/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/ | |||
| # /?content=http://localhost:24817/pulp/api/v3/content/file/fb8ad2d0-03a8-4e36-a209-77763d4ed16c/ | |||
There was a problem hiding this comment.
this needs to be just the relative URL without the hostname and port. What was here before was wrong.
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 Also fix a related issue with a URL in a comment: It should be relative rather than absolute. [noissue]
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue]
dkliban
approved these changes
Apr 11, 2019
mikedep333
added a commit
to mikedep333/pulp-ci
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_rpm
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/ansible-pulp
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
dkliban
pushed a commit
to pulp/pulp-certguard
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
dkliban
pushed a commit
to pulp/pulp-certguard
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/plugin_template
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/plugin_template
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_cookbook
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_cookbook
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_gem
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_gem
that referenced
this issue
Apr 11, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_gem
that referenced
this issue
Apr 12, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
mikedep333
added a commit
to mikedep333/pulp_gem
that referenced
this issue
Apr 12, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this issue
May 14, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this issue
May 14, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
daviddavis
pushed a commit
to daviddavis/plugin_template
that referenced
this issue
Jul 8, 2019
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
daviddavis
pushed a commit
to daviddavis/plugin_template
that referenced
this issue
Jul 8, 2019
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
ThikaXer
pushed a commit
to ATIX-AG/pulp_deb
that referenced
this issue
Oct 5, 2020
https://pulp.plan.io/issues/4556 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
ThikaXer
pushed a commit
to ATIX-AG/pulp_deb
that referenced
this issue
Oct 5, 2020
https://pulp.plan.io/issues/4594 Content: 8080 -> 24816 API: 8000 -> 24817 [noissue] Required PR: pulp/pulpcore#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change Pulp 3 Default Ports
https://pulp.plan.io/issues/4556
Update docs for changed Pulp 3 Default Ports
https://pulp.plan.io/issues/4594
Content: 8080 -> 24816
API: 8000 -> 24817
This commit includes a change to docs/Makefile that affects the build process.
Note: I am about to submit changes to ansible-pulp & several other repos too. The travis files exist in those other repos in addition to doc updates. They probably all need to be merged at the same time.
Required PR: #79