Fix custom operation_id's from OpenAPI #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7341 |
fao89
commented
Aug 24, 2020
pulpcore/openapi/__init__.py
Outdated
Comment on lines
70
to
72
| action_name = getattr(self.view, "action", self.method.lower()) | ||
| if action_name not in ["retrieve", "list", "destroy", "create"]: | ||
| return action_name |
There was a problem hiding this comment.
I'm looking for customized action such as: sync and modify.
So if we get a customized action, we return it.
fao89
commented
Aug 24, 2020
| if self.method.lower() == "get" and self._is_list_view(): | ||
| return "list" | ||
|
|
||
| return self.method_mapping[self.method.lower()] |
There was a problem hiding this comment.
the default actions are handled here
ipanova
approved these changes
Aug 24, 2020
fao89
commented
Aug 24, 2020
Comment on lines
+302
to
+307
| tokenized_path = schema._tokenize_path() | ||
| tokenized_path = "_".join( | ||
| [t.replace("-", "_").replace("/", "_").lower() for t in tokenized_path] | ||
| ) | ||
| action = schema.get_operation_id_action() | ||
| if f"{tokenized_path}_{action}" == operation["operationId"]: |
There was a problem hiding this comment.
this assures to return only the action for the bindings.
rpm_rpm_repositories_list -> list
rpm_rpm_repositories_sync - > sync
dralley
reviewed
Aug 24, 2020
| action = action_name.replace("destroy", "delete").replace("retrieve", "read") | ||
| tokenized_path = schema._tokenize_path() | ||
| tokenized_path = "_".join( | ||
| [t.replace("-", "_").replace("/", "_").lower() for t in tokenized_path] |
There was a problem hiding this comment.
Could you explain what's going on here?
There was a problem hiding this comment.
Please check if the docstrings I've added are enough or if I have to make an inline comment here
[noissue]
dralley
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/7341
closes #7341
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html