Fixed: PulpTemporaryFile stored in the wrong location #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/7319 |
|
We already merged:
With this PR, and maybe with https://pulp.plan.io/issues/7329 |
|
As much as i believe this is doing the trick, would you mind adding a unittest for it? I think, you can almost use the example from the ticket (creating a PTFile, checking it's path, try reading it). |
ipanova
approved these changes
Aug 26, 2020
|
@fao89 can you update the reference to the Artifactfilefield in the doc blocks? |
fao89
force-pushed
the
7319
branch
8 times, most recently
from
dcc3a24
to
dc4bb01
Compare
mdellweg
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/7319
closes #7319
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html