Using check-manifest to update manifest #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
issue7656
branch
2 times, most recently
from
939584b
to
c19b8c9
Compare
|
Attached issue: https://pulp.plan.io/issues/7656 |
bmbouter
reviewed
Oct 12, 2020
| "HISTORY.rst", | ||
| "dev_requirements.txt", | ||
| "doc_requirements.txt", | ||
| "docs/**", |
There was a problem hiding this comment.
Does this mean we're not including the docs in our shipped python wheels? Or are they still included in the sdists? Do we publish sdists or wheels only?
There was a problem hiding this comment.
I'm hoping someone with more knowledge of our packaging weighs in here but I believe we aren't shipping docs with our wheels. Not sure about your other questions.
There was a problem hiding this comment.
FWIW, MANIFEST.in affects sdists only, not bdists like wheels. So I believe docs are not included in the sdists.
Not sure what is included into bdists by default.
goosemania
approved these changes
Oct 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7656
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html