Skip to content
This repository has been archived by the owner on Nov 23, 2020. It is now read-only.

Add dependent repositories as submodules #3

Merged
merged 1 commit into from Jan 31, 2019

Conversation

mdellweg
Copy link
Member

Activate use of galaxy_role_file (change in forklift needed).

[noissue]

@mdellweg
Copy link
Member Author

mdellweg commented Jan 24, 2019

You might need to make the commit from theforeman/forklift#908 available.

edit: Now merged upstream.

@mdellweg
Copy link
Member Author

I didn't intend this, but the problem that forklift upstream was able to break pulplift is (i think) one reason more to use forklift as a submodule.

@CodeHeeler
Copy link
Contributor

Thanks so much for this fix! I've created an issue [0] for this work as it really helps us track changes for build and qe. If you'd be so kind as to reference it instead of noissue in your commit, I'd really appreciate it. Feel free to update the issue as you see fit if my description was inaccurate.

[0] https://pulp.plan.io/issues/4367

@asmacdo
Copy link
Contributor

asmacdo commented Jan 31, 2019

@mdellweg could you also update the docs for installation? Since you delete the setup script, I'm confused how this will work.

The setup script is also mentioned here: https://docs.pulpproject.org/en/3.0/nightly/contributing/dev-setup/index.html#developer-setup

IMO, the pulp docs should just say "Use the pulplift docs" and link so we don't need to tweak those docs when we make changes here. If you don't mind, could you update those docs as well? Alternatively, we could just file an issue to do that and go ahead and merge this.

Activate use of galaxy_role_file (change in forklift needed).

closes #4367
https://pulp.plan.io/issues/4367
@asmacdo asmacdo merged commit 8a47596 into pulp:master Jan 31, 2019
@mdellweg mdellweg deleted the ansible_galaxy_role_file branch January 31, 2019 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants