RFC: Testing nested Virtualization #66
Conversation
mikedep333
changed the title
mikedep333
force-pushed
the
test-nested-virt
branch
6 times, most recently
from
81b3643
to
cda7621
Compare
.github/workflows/ci.yaml
Outdated
| debug: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Setup tmate session | ||
| uses: mxschmitt/action-tmate@v1 |
There was a problem hiding this comment.
we should remove it, otherwise CI will keep running
[noissue]
Travis: Test kvm [noissue]
mikedep333
force-pushed
the
test-nested-virt
branch
5 times, most recently
from
58226b3
to
d00430b
Compare
[noissue]
mikedep333
force-pushed
the
test-nested-virt
branch
2 times, most recently
from
dd9d47d
to
ff3ab9f
Compare
Works around centos7 failing to instal redis due to lack of epel7 being installed in pulp_redis role.
mikedep333
force-pushed
the
test-nested-virt
branch
from
ff3ab9f
to
8c9e2a8
Compare
which I think is caused by old vagrant not supporting centos8-stream.
mikedep333
force-pushed
the
test-nested-virt
branch
from
ad08f2b
to
5cd0a88
Compare
mikedep333
force-pushed
the
test-nested-virt
branch
from
138c42b
to
f1ab9e1
Compare
mikedep333
force-pushed
the
test-nested-virt
branch
from
f1ab9e1
to
1f05e13
Compare
mikedep333
force-pushed
the
test-nested-virt
branch
from
15ffd41
to
ae36231
Compare
Fixes issue that would require vagrant-sshfs 1.3.5, but debian family only has 1.3.4.
|
Closing in favor of #95 , which is squashed and tests with hardware KVM on Travis exclusively. I will continue the branch test-nested-virt for occasional experimenting though. |
.github/workflows/ci.yaml
Outdated
| @@ -26,7 +26,7 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| set -xmveuo pipefail | |||
| git submodule update --init || true | |||
| git submodule update --init --remote || true | |||
There was a problem hiding this comment.
This is IMHO not the way, submodules should be used. They are powerful, because they refer to a known to work commit in the subrepository.
And the CI should show, that this specific combination of revisions work.
There was a problem hiding this comment.
Maybe we want another kind of relation between those repositories, but then we should stop using submodules.
There was a problem hiding this comment.
@mdellweg I just noticed this comment now.
In the pulplift CI PR, I actually updated the user instructions with "--remote":
https://github.com/pulp/pulplift/pull/95/files#diff-04c6e90faac2675aa89e2176d2eec7d8R28
I am open to other ideas, I just think this is the best way of handling this for now. Particular in terms of maintenance. Devs should just run that command from time to time.
In the long run, a bot would be great, but we are using Travis, not GHA. And I thought bots are less feasible on Travis.
If other repos start to break us, we will at least find out in our CI, and be able to quickly adjust the CI scripts and instructions.
mikedep333
force-pushed
the
test-nested-virt
branch
from
d0cb70d
to
ccbe9e0
Compare
Referenced in this email report:
https://www.redhat.com/archives/pulp-dev/2020-February/msg00064.html