Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Features page and change to drop down menu #259

Merged
merged 2 commits into from May 28, 2020
Merged

Add Features page and change to drop down menu #259

merged 2 commits into from May 28, 2020

Conversation

melcorr
Copy link
Collaborator

@melcorr melcorr commented May 8, 2020

I wrote a draft Features page, which I hoped to distribute to the pulp-dev list for feedback and further input.

https://melcorr.github.io/pulpproject.org/

As part of this, I want to create a drop-down menu item titled Pulp 3 after Home

Within Pulp 3 I wanted to nest the About Pulp 3 page and also the new Features page. I planned to expand this with further content next week.

@bmbouter helped me resolve the issue with adding a drop-down menu to the topnav.

I removed the "Home" link from the navigation, largely because it annoyed me, as we have a home icon and the Pulp icon that brings the user to the home page.

Thanks!

@melcorr melcorr requested a review from bmbouter May 8, 2020 17:39
@melcorr melcorr changed the title [WIP] Add Features page and change to drop down menu Add Features page and change to drop down menu May 15, 2020
pulp-3-features.md Outdated Show resolved Hide resolved
@ipanova
Copy link
Member

ipanova commented May 26, 2020

@melcorr do you think this a good idea to move pulp3 plugins under pulp3 as well?

pulp-3-features.md Outdated Show resolved Hide resolved
@melcorr
Copy link
Collaborator Author

melcorr commented May 26, 2020

@melcorr do you think this a good idea to move pulp3 plugins under pulp3 as well?

To address the issue on the pulp-dev thread that @bmbouter and @goosemania highlighted, I have created a draft page called "Content Plugins" that introduces the plugin concept and then has a list of differences between Pulp 2 and Pulp 3 aka *The File plugin replaces ISO in the Pulp 2 rpm * etc and then has a table for Pulp 3 plugins and a table for Pulp 2 plugins. I will post the PR for that once I get this one finished.

I was thinking of having Content Plugins on the main menu, and haven't thought ahead of that.

I am also thinking of creating a page per Pulp 3 plugin, or one page with more detail on each Pulp 3 plugin. I have some research to do and perhaps need to discuss this a bit more with you and the team.

Let me know your thoughts!

@ipanova
Copy link
Member

ipanova commented May 26, 2020

@melcorr do you think this a good idea to move pulp3 plugins under pulp3 as well?

To address the issue on the pulp-dev thread that @bmbouter and @goosemania highlighted, I have created a draft page called "Content Plugins" that introduces the plugin concept and then has a list of differences between Pulp 2 and Pulp 3 aka *The File plugin replaces ISO in the Pulp 2 rpm * etc and then has a table for Pulp 3 plugins and a table for Pulp 2 plugins. I will post the PR for that once I get this one finished.

I was thinking of having Content Plugins on the main menu, and haven't thought ahead of that.

I am also thinking of creating a page per Pulp 3 plugin, or one page with more detail on each Pulp 3 plugin. I have some research to do and perhaps need to discuss this a bit more with you and the team.

Let me know your thoughts!

in the next PR you plan to replace pulp3 plugins with content plugins that will work for me

* Add Pulp 3 menu item
* Add features page
* Remove extra Home button
@melcorr melcorr merged commit f6e52a0 into pulp:gh-pages May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants