This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
Several updates based on discussion #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The name PUP is now used. * PUPs will live as pull requests until a decision is made. * A dedicated repo will now be used instead of pulpproject.org. * Voting uess a minimum of 12 days instead of 10. * The alternative of using Github for feedback is removed because feedback is now allowed directly on the pull request in addition to the mailing list. * The alternative of keeping PUPs as pull requests has been adopted and has been removed from the alternatives section. * Several minor grammer and wording edits. * A README.md was added
daviddavis
suggested changes
Mar 21, 2017
pup-0001.md
Outdated
|
|
||
|
|
||
| Pre-Proposal | ||
| ^^^^^^^^^^^^ |
There was a problem hiding this comment.
I don't think upticks work in markdown.
There was a problem hiding this comment.
There was a problem hiding this comment.
Fixed in next push and I'm proofreading the page myself too using the github markdown this time. Thank you.
pup-0001.md
Outdated
| * -1: "Not the right choice and should definitely not be adopted." This type of feedback must come | ||
| with a statement of objective concerns explaining what harm will come from adopting the proposal. | ||
|
|
||
| Note that votes can come from anyone, not just core devs [#f1]_. This is directly modeled after [the |
There was a problem hiding this comment.
This footnote link doesn't work in markdown. The underscore italicizes text.
pup-0001.md
Outdated
|
|
||
| This is a modified version of [the Foreman template](https://github.com/theforeman/rfcs/blob/master/0000-template.md). | ||
|
|
||
| :: |
There was a problem hiding this comment.
Not needed in markdown.
daviddavis
approved these changes
Mar 22, 2017
|
With two +1 votes via the mailing list after the required amount of time, I'm merging it as approved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feedback is now allowed directly on the pull request in addition to
the mailing list.
has been removed from the alternatives section.