This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
Adding process for revising accepted PUPs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
revising-pups
branch
2 times, most recently
from
8591a0c
to
0adf984
Compare
CodeHeeler
approved these changes
Jul 9, 2018
asmacdo
reviewed
Jul 20, 2018
pup-0001.md
Outdated
| Even after a PUP has been accepted, it may be revised. The process for changing a PUP is the same as | ||
| creating a new PUP. This process starts with a discussion followed by a PR to change the existing | ||
| PUP. Then a voting period occurs which is decided by lazy consensus. If the vote passes, the PR is | ||
| then merged. |
There was a problem hiding this comment.
Can you add something about incrementing the version?
There was a problem hiding this comment.
Also, increment the version for this PR https://github.com/pulp/pups/pull/11/files#diff-310a4711bed05142430bdaac987dc561R4
daviddavis
force-pushed
the
revising-pups
branch
from
0adf984
to
62169dd
Compare
asmacdo
approved these changes
Jul 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.