Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

Display CoC on website #12

Merged
merged 1 commit into from Aug 7, 2018
Merged

Display CoC on website #12

merged 1 commit into from Aug 7, 2018

Conversation

CodeHeeler
Copy link
Contributor

No description provided.

@daviddavis
Copy link
Contributor

The version number needs to be set to 2 in the header. See this as an example:

https://github.com/pulp/pups/pull/11/files#diff-310a4711bed05142430bdaac987dc561R4

CONTRIBUTING.md file in the root of the pulp Git repository. Each Pulp plugin
will be encouraged to include a link to the CoC above in a CONTRIBUTING.md file
in the root of its repository.
The text of the CoC will reside on our website at https://pulpproject.org/conduct/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The period was deliberately omitted so as not to get in the way of the link. If you think "/conduct/." is not confusing, it can be added.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. What about maybe quoting it (ie reside on our website at "https://pulpproject.org/conduct/".)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with leaving it as is too.

The display details are updated to provide the COC text on our
website and link to it from a CODE_OF_CONDUCT.md file.
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daviddavis daviddavis merged commit d6b1225 into pulp:master Aug 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants