Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

Replaces concensus with lazy concensus #5

Merged
merged 3 commits into from Aug 17, 2017
Merged

Replaces concensus with lazy concensus #5

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e13e2d7
Replaces concensus with lazy concensus
Jun 26, 2017
959c67f
Revisions based on comments left
Jul 31, 2017
f5b7282
Clarifying if author(s) vote
Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Revisions based on comments left 
* Adjusts the +1 approvals to come from anywhere, not just core devs
* Explicitly allows for votes to be recast
* Explains two examples where votes are recast. One is based on many
  other -1 votes being cast. The other is when concerns are addressed
  and a -1 vote is recast.
  • Loading branch information
Brian Bouterse committed Jul 31, 2017
commit 959c67f5a4d16a26e1d97ea6fe4aa570066db768
19 changes: 12 additions & 7 deletions pup-0001.md
View file
Open in desktop
Expand Up @@ -95,20 +95,25 @@ announcement/discussion thread on the mailing list. The voting has the following
* +1: "Will benefit the project and should definitely be adopted."
* +0: "Might benefit the project and is acceptable."
* -0: "Might not be the right choice but is acceptable."
* -1: "Not the right choice and should definitely not be adopted."
* -1: "I have serious reservations that need to be thought through and addressed."


### Accepting/Rejecting

* A PUP is accepted with two, +1 votes from core devs [1] and no blocking (-1) votes from core devs.
* +/- 0 votes inform support or dissent but do not pass or block a pup. The stated concerns may
influence other people to have blocking reservations.
* A PUP is accepted with two +1 votes from anyone and no blocking -1 votes from core devs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does 'anyone' mean community member?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes anyone effectively means 'community member'. It was added based on some comments from the last round.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the author an assumed +1, or is it the author +2 positive votes? I assume tha latter.

Copy link
Member Author

@bmbouter bmbouter Aug 10, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author's vote is not assumed. They can abstain or vote. If an author votes +1 (very likely), an additional +1 is required to pass. I'm pushing a 2-line clarifying change in the next commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That clarifying language commit is here: f5b7282

* +/- 0 votes inform support or dissent but do not pass or block a PUP. The stated concerns with a
-0 vote may influence other people to have blocking reservations.
* A -1 vote from a core dev [1] is considered a blocking vote and must be accompanied with
substantive arguments.
* Stated concerns with a blocking vote can be used to revise a PUP until the blocking vote is
recast.
* Votes can come from anyone, not just core devs [1] and are used as data points.
* Core devs [1] are expected to consider and echo serious feedback from the community, especially
recast or the PUP is withdrawn.
* Votes can be recast. Common reasons for doing so include on-going discussion or from observing
other votes that have been cast. For example, a -1 vote could be recast to a non-blocking vote due
to changes that have been made in the PUP to address their concerns. Another example is recasting
a vote to a -1 based on observing many -0 votes which indicate a PUP does not have broad support
even with enough +1 votes to pass.
* Votes can come from anyone, not just core devs [1].
* Core devs [1] are expected to consider and echo serious concerns from the community, especially
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: s/serious// but feel free to leave as is.

any -1 votes from community members.


Expand Down