Skip to content
This repository has been archived by the owner on Nov 2, 2020. It is now read-only.

Adding Code of Conduct #6

Merged
merged 5 commits into from Jan 10, 2018
Merged

Adding Code of Conduct #6

merged 5 commits into from Jan 10, 2018

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented Dec 7, 2017

No description provided.

pup-0004.md Outdated
The [Django CoC](https://www.djangoproject.com/conduct/) is an alternative code
of conduct that we could adopt.

### Adop a CoC that we write as a committee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Adop/Adopt/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could say something like: We probably could not produce a better document since we have no background in this area.

pup-0004.md Outdated
## Motivation

Currently Pulp does not have a CoC. A community's CoC helps foster an open and
inclusive environment. It also enables the community to enforce openness and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One space after a period. Similar throughout.

pup-0004.md Outdated

## Drawbacks

This CoC does not identify anything specific about the Pulp community.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One challenge will be that enforcement and response is not very clear and can be subjective. We can acknowledge that by listing it as a stated drawback.

Copy link
Member

@ipanova ipanova Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think a lot of laws preserve this kind of approach, actually most of them, list common situations that could happen and for the rest they just reserve the right and freedom to accordingly act in the situation with a good will. So i would not take this as a drawback.

@daviddavis
Copy link
Contributor

LGTM

pup-0004.md Outdated

This PUP is to adopt a Code of Conduct (CoC) for the Pulp community. The PUP
also establishes an email address for reporting violations of the CoC. PUP also
establishes how the CoC is displayed to community members.
Copy link
Contributor

@dralley dralley Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rewording:

This PUP is to adopt a Code of Conduct (CoC) for the Pulp community, and 
establishes how the CoC will be displayed to community members. The PUP
also establishes an email address for reporting violations of the CoC.

@goosemania
Copy link
Member

Looks good to me.

pup-0004.md Outdated
## Displaying the CoC

A link to the CoC above will be provided in the "Code of Conduct" section of
CONTRIBUTING.md file in the root of the pulp Git repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/pulp/Pulp/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is it worth putting this in the root of each plugin that considers itself part of the Pulp community?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll have a separate PUP for that. What do others think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just add a sentence here: "We recommend that Pulp plugins also include a link to our Code of Conduct in a CONTRIBUTING.md file in the root of their repositories."

@asmacdo
Copy link
Contributor

asmacdo commented Dec 8, 2017

+1 Thanks @dkliban

pup-0004.md Outdated
title: Code of Conduct
author: Dennis Kliban
created: 06-Dec-2017
status: Active
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Active/Approved/

If this gets merged, it's approved :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to changing this now so it's in it's final form.


## Summary

This PUP is to adopt a Code of Conduct (CoC) for the Pulp community, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/is to adopt/adopts/
/and/and it/


## Motivation

Currently Pulp does not have a CoC. A community's CoC helps foster an open and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Pulp/the Pulp community/

## Motivation

Currently Pulp does not have a CoC. A community's CoC helps foster an open and
inclusive environment. It also enables the community to enforce openness and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enforce openness and inclusivity/address openness and inclusivity issues.

@dkliban dkliban merged commit 53485f3 into pulp:master Jan 10, 2018
@dkliban dkliban deleted the pup4 branch January 10, 2018 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants