Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

This provides an vertical tab implementation so we can get some user feedback from people in discord.

@trickypr trickypr added the enhancement New feature or request label Nov 29, 2022
@trickypr trickypr requested a review from PressJump November 29, 2022 10:49
@trickypr trickypr linked an issue Nov 29, 2022 that may be closed by this pull request
4 tasks
@trickypr
Copy link
Member Author

Should not close the issue

@trickypr trickypr marked this pull request as draft November 29, 2022 23:49
@trickypr trickypr mentioned this pull request Dec 3, 2022
4 tasks
@trickypr trickypr marked this pull request as ready for review December 3, 2022 09:00
@PressJump
Copy link
Member

PressJump commented Dec 12, 2022

Hey, this looks very nice but it does take a large amount of space on screen including if the user wanted to utilize the sidebar. It would be great if the user was able to resize the vertical tabs page to their liking dependent on the content they are looking at.
image
What are your thoughts?

@trickypr
Copy link
Member Author

See #137

  • Clean up the pulse theme
  • Add the option to compress the tabs down to just the favicon when not hovered

The point of this is to get a basic implementation. I will do better styling, experiment with docking the sidebars to the right etc. in another PR.

@PressJump
Copy link
Member

See #137

  • Clean up the pulse theme
  • Add the option to compress the tabs down to just the favicon when not hovered

The point of this is to get a basic implementation. I will do better styling, experiment with docking the sidebars to the right etc. in another PR.

Fair.

Copy link
Member

@PressJump PressJump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Vertical tabs community will like this one.

@trickypr trickypr merged commit bbcb24c into alpha Dec 12, 2022
@trickypr trickypr deleted the vertical-tabs branch December 12, 2022 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical tabs

3 participants