Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

Firefox Update

This bumps Firefox up to 107.0.1 for security and performance reasons. Reviewers check the following before continuing:

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar - There is still the race condition reported in pulse-browser/sidebartabs#2
    • Sidebar-Tabs can remove a sidebar item to the sidebar - An error here causes the addon to crash

Note: Neither sidebar issue are related to the update.

  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QRCode generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox

Depends on #170
Fixes #156

@trickypr trickypr requested a review from PressJump December 11, 2022 11:17
@fushra-robot fushra-robot added the dependent Requires another bug or pull request to be merged label Dec 11, 2022
@PressJump
Copy link
Member

Hmm, interesting that the sidebar issues are related to extension. Thats a new one.

@trickypr
Copy link
Member Author

The relevant error has been popping up regularly for ages, so it is nothing new

@fushra-robot fushra-robot removed the dependent Requires another bug or pull request to be merged label Dec 11, 2022
@fushra-robot
Copy link
Member

@PressJump
Copy link
Member

PressJump commented Dec 12, 2022

The relevant error has been popping up regularly for ages, so it is nothing new

There is an error but this does not block the functionality of the sidebar so QA for sidebar should be all good. This issue was fixed on pulse-browser/sidebar-tabs#4 so that error will stop showing up in console when merged.

@PressJump
Copy link
Member

PressJump commented Dec 12, 2022

Depends on pulse-browser/sidebar-tabs#4

@trickypr
Copy link
Member Author

Replaced by #175

@trickypr trickypr closed this Dec 17, 2022
@trickypr trickypr deleted the 107.0.1 branch April 25, 2023 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

❗ Pulse has out of date dependencies

4 participants