Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

Firefox Update

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar - There is still the race condition
    • Sidebar-Tabs can remove a sidebar item to the sidebar - For some reason removing items from the sidebar is working again. Not sure why.
  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QRCode generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox

@trickypr trickypr requested a review from PressJump December 17, 2022 05:16
@trickypr trickypr mentioned this pull request Dec 17, 2022
33 tasks
@trickypr
Copy link
Member Author

Probably should pull this and make sure that vertical tabs etc work

@trickypr trickypr marked this pull request as draft December 17, 2022 05:17
@PressJump

This comment was marked as resolved.

@trickypr trickypr marked this pull request as ready for review December 17, 2022 05:29
@trickypr

This comment was marked as resolved.

@PressJump

This comment was marked as resolved.

Copy link
Member

@PressJump PressJump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 108.0🎉

@splatboydev
Copy link
Contributor

🥳

@trickypr trickypr merged commit 30c87a2 into alpha Dec 18, 2022
@trickypr trickypr deleted the 108.0 branch December 18, 2022 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants