Problem with generated jar Manifest #1

Closed
jpospychala opened this Issue Nov 16, 2012 · 10 comments

Projects

None yet

5 participants

@jpospychala

hi Robert,
I noticed that generated getcomposer plugin has wrong version number in META-INF/MANIFEST.MF - it's 0.0.1.qualifier, so qualifier was not replaced with actual version timestamp.
You can see this e.g in package available here: http://p2-dev.pdt-extensions.org/plugins/org.getcomposer.core_0.0.1.201210132023.jar

I think this should be possible to fix by changing pom.xml to use tycho-maven-plugin instead of maven-jar-plugin

@pulse00
Owner
pulse00 commented Nov 16, 2012

@jpospychala i've planned some work on my eclipse plugins this weekend - i'll look into this too, thanks for the tip.

@nataliab
Contributor

Robert,
You can try to use plugins:

tycho-maven-plugin
tycho-packaging-plugin

and

eclipse-plugin

in your pom.xml

@nataliab
Contributor
nataliab commented Dec 4, 2012

Hi Robert,

Do you have any plans on fixing this issue?
It seems to be as easy as changing the packaging in pom.xml from 'jar' to 'eclipse-plugin'.

@pulse00
Owner
pulse00 commented Dec 4, 2012

@nataliab sorry for the delay, i'm currently a little too busy to work on the eclipse plugins :(

As far as i remember i initially had set it to eclipse-plugin, but then it does not compile as a standalone library - at least the travis build fails during compilation. That's why i reverted to plain jarpackaging.

All there is to make it work in an OSGI environment is the MANIFEST.MF. If you look at the Manifest of the composer plugin, you'll see that i simply export the package there, so it's available to the OSGI autoloader.

Am i misunderstanding something? i'm not too firm with the OSGI world.

@nataliab
Contributor
nataliab commented Dec 4, 2012

The problem is that the MANIFEST.MF of this plugin contains
Bundle-Version: 0.0.1.qualifier
what is not correct. Qualifier should be replaced with a timestamp during build, otherwise it's confusing for OSGI environemnt.
tycho does this automatically if you package as eclipse-plugin. Maybe you could give eclipse-plugin packaging another try (and solve compilation problems in a different way)?

@pulse00
Owner
pulse00 commented Dec 4, 2012

@nataliab i see. i can switch back to eclipse-plugin packaging and delay the compilation problem to later time ;) i hope a can find some time this week.

@nataliab
Contributor
nataliab commented Dec 5, 2012

Robert,
I see there is new version 0.0.7.201212042111 of com.dubture.composer.feature, but the org.getcomposer jar has not been rebuilt - it's still org.getcomposer.core_0.0.1.201210132023. Could you rebuild it?

@pulse00
Owner
pulse00 commented Mar 7, 2013

@nataliab @jpospychala the org.getcomposer.jar is updated to 0.0.2 to make sure it's updated during the build - there was a glitch in the submodule setup in the nightly build.

@gossi
Collaborator
gossi commented Jun 5, 2013

Is this still an issue with the newest release of the composer plugin and the java bindings? Like, can this issue be closed?

@pulse00
Owner
pulse00 commented Jun 6, 2013

afaik it's fixed.

@zulus zulus closed this Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment