Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Grid2D when range is not divisible by step #201

Merged
merged 3 commits into from Jun 3, 2020

Conversation

mbeyeler
Copy link
Member

@mbeyeler mbeyeler commented Jun 3, 2020

Fixes the problem where the step size returned by Grid2D is slightly off, because the specified range is not divisible by step (issue #200)

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #201 into master will increase coverage by 0.05%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   90.15%   90.21%   +0.05%     
==========================================
  Files          69       69              
  Lines        5658     5690      +32     
==========================================
+ Hits         5101     5133      +32     
  Misses        557      557              
Flag Coverage Δ
#unittests 90.21% <96.92%> (+0.05%) ⬆️
Impacted Files Coverage Δ
pulse2percept/percepts/base.py 96.22% <66.66%> (ø)
pulse2percept/utils/geometry.py 83.62% <88.88%> (+0.58%) ⬆️
pulse2percept/models/base.py 86.99% <100.00%> (ø)
pulse2percept/models/beyeler2019.py 94.11% <100.00%> (ø)
pulse2percept/models/tests/test_base.py 98.61% <100.00%> (ø)
pulse2percept/models/tests/test_beyeler2019.py 100.00% <100.00%> (ø)
pulse2percept/models/tests/test_nanduri2012.py 100.00% <100.00%> (ø)
pulse2percept/percepts/tests/test_base.py 100.00% <100.00%> (ø)
pulse2percept/utils/__init__.py 100.00% <100.00%> (ø)
pulse2percept/utils/tests/test_geometry.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e630649...94c2654. Read the comment docs.

@mbeyeler mbeyeler merged commit 41ff68f into pulse2percept:master Jun 3, 2020
@mbeyeler mbeyeler deleted the fix-grid branch June 3, 2020 17:16
@mbeyeler mbeyeler added this to the v0.7 milestone Aug 19, 2020
@mbeyeler mbeyeler linked an issue Aug 22, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid step wrong in some cases
2 participants