[FIX] Show warning when Scoreboard / AxonMap models are used with implant.z > 0 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 93.90% 93.98% +0.08%
==========================================
Files 85 85
Lines 7181 7220 +39
==========================================
+ Hits 6743 6786 +43
+ Misses 438 434 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mbeyeler
added a commit
that referenced
this pull request
Jun 22, 2021
* Increment version number * [FIX] Axon map in Argus plotters (#366) * fix axon map in Argus plotters * fix typo * fix more typos * [FIX] Axon map plot for left eyes (#367) * [DOC] Update release notes * [FIX] Show warning when Scoreboard / AxonMap models are used with implant.z > 0 (#368) * [ENH] Speed up AxonMap build (#369) * replace np.insert with np.concatenate * Update release notes * [FIX] Axon map usability (#370) * Raise ValueError when lambda is too small * Add note in the docs about resetting parameters * Fix axon map docs, refactor axon methods * remove axon map legacy build * Update release notes * [ENH] Update Nanduri2012 data (#376) * updated nanduri dataset * Updated / added test cases * Add docstring for new column * Fixed docstring for new column * [ENH] Speed up ElectrodeArray.plot() (#375) * speed up implant.plot * Update release notes * update test * [ENH] Add FadingTemporal model (#378) * Add FadingTemporal model * Fix docs and release notes * [FIX] Percept plotting and animation (#379) * fix plot method * remove get_interval, use utils.unique instead * Fix Matplotlib deprecation error * [FIX] BVT24 electrode naming convention (#380) * [ENH] Various performance enhancements (#382) * speed up stim.compress() * Speed up alphabetic electrode numbering * fix typo * fix contiguous error * add new cython submodule * refactor Nanduri Cython * Refactor Horsager Cython * Refactor Beyeler Cython * add cumpow function * [ENH] Various implant upgrades (#383) * Update earray indexing * fix is_charge_balanced * add easy conversion from ImageStimulus, VideoStimulus to implant.stim * Activate/deactivate electrodes * [DOC] Fix CircleElectrodeArray * [FIX] BarStimulus, GratingStimulus docs (#384) * [ENH] Various stimulus upgrades (#385) * Speed up VideoStimulus init * Fix rgb2gray for a video that's already grayscale * Speed up Stimulus init * replace np.isclose with math.isclose for speedup * Switch monotonic ValueError to warning * Add video.trim() * [FIX] Order of display items in implant plots (#386) * add constants; fix np.bool deprecation warning * adjust alpha of electrode plots * Don't expose constants at the module level * [FIX] plot_sinusoidal example * [FIX] Add docstrings for constants * Prepare Release 0.7.1 (#387) * Prepare Release 0.7.1 * Add MANIFEST.in Co-authored-by: Jacob Granley <jgranley@ucsb.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although implants have an
electric_potentialmethod,ScoreboardModelandAxonMapModeldo not make use of it. Therefore, setting an electrode's z value > 0 does not have an effect on the model output. This is now being communicated to the user with a warning message (closes issue #169)