Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Grid2D plot when step is a tuple #446

Merged
merged 1 commit into from Dec 7, 2021

Conversation

mbeyeler
Copy link
Member

@mbeyeler mbeyeler commented Dec 6, 2021

This PR fixes issue #442, when step of a Grid2D object is a tuple:

p2p.utils.Grid2D((-5, 5), (-5, 5), step=(0.5, 1)).plot(style='cell')

image

@mbeyeler mbeyeler added this to the v0.8 milestone Dec 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #446 (fe952b8) into master (7a9da85) will increase coverage by 0.10%.
The diff coverage is 95.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   93.83%   93.93%   +0.10%     
==========================================
  Files          90       90              
  Lines        7782     7868      +86     
==========================================
+ Hits         7302     7391      +89     
+ Misses        480      477       -3     
Flag Coverage Δ
unittests 93.93% <95.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pulse2percept/viz/tests/test_base.py 100.00% <ø> (ø)
pulse2percept/utils/images.py 91.54% <50.00%> (-1.21%) ⬇️
pulse2percept/implants/base.py 94.95% <82.14%> (-2.96%) ⬇️
pulse2percept/models/base.py 87.64% <83.33%> (+0.28%) ⬆️
pulse2percept/viz/base.py 88.67% <90.90%> (-0.69%) ⬇️
pulse2percept/utils/geometry.py 90.17% <91.52%> (+3.59%) ⬆️
pulse2percept/models/granley2021.py 93.64% <94.44%> (+0.78%) ⬆️
pulse2percept/models/beyeler2019.py 95.66% <95.00%> (-0.16%) ⬇️
pulse2percept/implants/bvt.py 90.90% <100.00%> (-0.99%) ⬇️
pulse2percept/implants/electrode_arrays.py 95.15% <100.00%> (+0.32%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7860999...fe952b8. Read the comment docs.

@mbeyeler mbeyeler merged commit 67e0f23 into pulse2percept:master Dec 7, 2021
@mbeyeler mbeyeler deleted the fix-grid-plot branch December 7, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Grid2D.plot(style='cell') fails for grid with different x, y steps
2 participants