refactor(mcp-auth): Phase 1 - Remove CLI tools and performance testing #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add convenience methods to simplify creating UI resources: - Content::ui_html(uri, html) - Create HTML UI resource (1 line vs 8) - Content::ui_resource(uri, mime_type, content) - Custom MIME types - Update ui-enabled-server example to use new helpers - Add comprehensive UI_RESOURCES_GUIDE.md documentation This reduces boilerplate by 87% for UI resource creation, making PulseEngine competitive with TypeScript SDK for ergonomics.
Remove non-library code from mcp-auth to focus on core functionality: - Delete CLI binaries (mcp-auth-cli, mcp-auth-setup, mcp-auth-init) - 3,759 lines - Delete performance.rs (benchmarking) - 840 lines - Delete setup/ directory (wizard) - 526 lines - Remove related dependencies (clap, dialoguer, colored, inotify) - Update lib.rs exports to remove deleted modules Total reduction: 5,125 lines (17% smaller) Final size: 25,112 lines → targeting 13K core in Phase 2 Addresses #64
PR Validation ResultsQuick Validation: ❌
Compatibility Check: ❌
Summary: ❌ Some checks failed |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First phase of slimming down mcp-auth from 30K LOC to ~13K core functionality (Issue #64). This phase removes clearly non-library code with zero risk to core auth functionality.
Changes
Deleted Components
mcp-auth-cli.rs- Full CLI tool for key managementmcp-auth-setup.rs- Setup wizardmcp-auth-init.rs- Initialization toolperformance.rs- Benchmarking codesetup/directory - Interactive setupDependencies Cleaned Up
clap,dialoguer,colored(CLI-only)inotify(Linux setup monitoring)libc(needed for Unix file permissions in storage)Impact
Before: 30,237 lines
After: 25,112 lines
Reduction: 5,125 lines (17% smaller)
Testing
cargo check --package pulseengine-mcp-authpassescargo build --workspacepassesWhat's Next
Phase 2 will convert remaining optional features to feature flags:
integrationfeature → integration framework (7,484 lines)monitoringfeature → dashboard/monitoring (2,154 lines)vaultfeature → enterprise vault support (1,004 lines)consentfeature → GDPR/CCPA compliance (455 lines)This will bring mcp-auth core down to ~13K lines while keeping all functionality accessible via opt-in features.
Related Issues
Addresses #64