-
-
Notifications
You must be signed in to change notification settings - Fork 135
Add copy and "move and organise" features #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"type" is deprecated, and using "buttonFactory" allow to add more than one button the the modal. Signed-off-by: Pıεяяε <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: Pıεяяε <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
Signed-off-by: airo.pi_ <47398145+AiroPi@users.noreply.github.com>
|
I intended to get to this before the 7.3 release but a hotfix came up that'll need an immediate release. Moving this ahead but 7.4 can come earlier. |
|
Happy new year 😄 |
|
I'm trying to find some documentation, but with no luck. What does exactly "Move and organize" do? How does it differ from "Move"? |
Some documentation could be welcomed but I don't really know where it could be present. There is a little website for the documentation, maybe here. To respond to your question, this feature is the implementation of #1111 which will not only move the photos, but also create a directory tree, sorting photos by year / months. |
A tooltip on hover for the "Move and organise" button might be the most intuitive option. I'm not familiar with the codebase, but if the button factory supports a title field, that might be the simplest solution.
Thanks — makes sense. Just to clarify: is the timestamp taken purely from EXIF metadata, or does it fall back to file modification times or other sources? |
It will respect the same rules than Memories use to sort the timeline, so yes, it fall back to file modification times etc... |
|
@AiroPi Thank you for this feature! I am currently migrating my photo collection to Nextcloud and therefore have many photos that need to be properly organized. I upload the photos to an upload folder, select them all, and then apply Move and Organize to move them. Normally, I select and move about 200 to 300 photos at once. But then, sometimes pictures are being moved to incorrect folders. For example, a picture from 2005 is moved to a folder for 2006, and with the months, there is, for instance, a folder 01 (January) that contains pictures from various months. When i select the wrong pictures (only about 10) an use Move and Organise on this pictures again it seems to work correct. Did anyone else notice this behavior? edit: Now i can reproduce the behaviour and can open a issue: #1544 |


This implements features #595 and #1111. It's my first time working with TypeScript, PHP, and Vue, so this is still a draft. I'm aware there are many things that need refactoring.
This adds two new buttons to the "move" modal called “Move and Organize” and "Copy".
To implement these features, I needed to make a few changes:
chooseNcFolderfunction slightly. It now takes abuttonFactoryinstead oftypeas the third argument.setTypewas deprecated anyway ingetFilePickerBuilder. The default value still behaves the same (providing the "Choose" option) so it doesn't break anything. Other types need to be defined manually.movePhotosByDatefunction fordav. This function first creates the required directories, then moves the files.By the way, the new
copyPhotosandmovePhotosfunctions are very similar and could be merged.